Skip to content

Indicator: add clear-app action - #359

Merged
danirabbit merged 4 commits into
mainfrom
danirabbit/indicator-clear-app-action
Sep 11, 2026
Merged

Indicator: add clear-app action#359
danirabbit merged 4 commits into
mainfrom
danirabbit/indicator-clear-app-action

Conversation

@danirabbit

@danirabbit danirabbit commented Sep 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@danirabbit
danirabbit requested a review from a team September 7, 2026 04:06
@danirabbit danirabbit added this to OS 9 Sep 7, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Sep 7, 2026

@vjr vjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to review (unfamiliar with the "action" aspects of) the code, seems OK to me, and fixes the issue with my quick tests, I think this can be merged.

The issue here #328 (comment) seems to still happen IFF the collapse/expand triangle was already expanded state before I sent test notifications and popped up the indicator but this might be a separate issue / already addressed by one of the other PRs.

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected.

@danirabbit
danirabbit enabled auto-merge (squash) September 11, 2026 16:24
@danirabbit
danirabbit merged commit 918869b into main Sep 11, 2026
2 of 4 checks passed
@danirabbit
danirabbit deleted the danirabbit/indicator-clear-app-action branch September 11, 2026 16:24
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants